Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solid-server to the list of node packages #27530

Closed
wants to merge 3 commits into from
Closed

Add solid-server to the list of node packages #27530

wants to merge 3 commits into from

Conversation

sauyon
Copy link
Member

@sauyon sauyon commented Jul 21, 2017 •
edited

Motivation for this change

Adding solid-server node package

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I'm pretty sure this package should also include systemd units and configuration for the solid server, but I was unsure about where to put those files.

EDIT: I also didn't commit commit the node-packages-v*.nix files because they contained a lot of unrelated changes.

@mention-bot
Copy link

@sauyon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @svanderburg, @8573 and @jlesquembre to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Jul 21, 2017

Please also add at least node-packages-v6.nix. Otherwise the package will be not available for install. You can later add a module to nixos/ to care of the configuration/systemd service part.

@sauyon
Copy link
Member Author

sauyon commented Jul 21, 2017

Should I revert everything that wasn't the solid package or leave it?

@Mic92
Copy link
Member

Mic92 commented Jul 21, 2017 •
edited

No just keep it we have not better workflow to handle nodejs.

@sauyon
Copy link
Member Author

sauyon commented Jul 24, 2017

Should I manually squash the commits or will you when you merge?

@globin
Copy link
Member

globin commented Aug 30, 2017

This is a merge conflict

@sauyon sauyon requested a review from FRidh as a code owner October 29, 2017 02:03
@FRidh
Copy link
Member

FRidh commented Feb 11, 2018

Closing because of inactivity.

@FRidh FRidh closed this Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sauyon @mention-bot @Mic92 @globin @FRidh @Janik-Haag