Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptodev: 1.8 -> 1.9 #27583

Merged
merged 1 commit into from Jul 24, 2017
Merged

cryptodev: 1.8 -> 1.9 #27583

merged 1 commit into from Jul 24, 2017

Conversation

NeQuissimus
Copy link
Member

@NeQuissimus NeQuissimus commented Jul 23, 2017 •
edited

Motivation for this change

Update for kernels >= 4.10
The download location seems offline.

Things done

Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Nox review:

[...]
Result in /tmp/nox-review-48bn2dud
total 36
lrwxrwxrwx 1 nequi users 72 Jul 23 11:07 result -> /nix/store/ysgxpx3c78dcavjrs9nggb9fr7k84vbp-cryptodev-linux-1.9-3.10.105
lrwxrwxrwx 1 nequi users 70 Jul 23 11:07 result-2 -> /nix/store/g5dkn5g0ydr15g8shv2wqf8f3rr5ifgn-cryptodev-linux-1.9-4.12.3
lrwxrwxrwx 1 nequi users 70 Jul 23 11:07 result-3 -> /nix/store/kr3syqa4cvl3wsgkrx3wdqr4jai2wjkr-cryptodev-linux-1.9-3.18.0
lrwxrwxrwx 1 nequi users 70 Jul 23 11:07 result-4 -> /nix/store/c5pndbl6rc5axh681fz995iizwv1wdkp-cryptodev-linux-1.9-4.12.3
lrwxrwxrwx 1 nequi users 70 Jul 23 11:07 result-5 -> /nix/store/kr3syqa4cvl3wsgkrx3wdqr4jai2wjkr-cryptodev-linux-1.9-3.18.0
lrwxrwxrwx 1 nequi users 70 Jul 23 11:07 result-6 -> /nix/store/3r8rj80msknbc8jk6lywhdz2xgkigvhj-cryptodev-linux-1.9-4.9.39
lrwxrwxrwx 1 nequi users 70 Jul 23 11:07 result-7 -> /nix/store/0szpdcyk5pp3rz4q2lljr65cad6pvhzf-cryptodev-linux-1.9-4.4.78
lrwxrwxrwx 1 nequi users 70 Jul 23 11:07 result-8 -> /nix/store/f69wx81l5w54bi8hd5lhrcg8vrmh8l8g-cryptodev-linux-1.9-4.12.2
lrwxrwxrwx 1 nequi users 70 Jul 23 11:07 result-9 -> /nix/store/g5dkn5g0ydr15g8shv2wqf8f3rr5ifgn-cryptodev-linux-1.9-4.12.3

@mention-bot
Copy link

@NeQuissimus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @viric and @edolstra to be potential reviewers.

joachifm
joachifm reviewed Jul 23, 2017
View reviewed changes
pkgs/os-specific/linux/cryptodev/default.nix Outdated
name = "${pname}-${kernel.version}";

src = fetchurl {
url = "http://download.gna.org/cryptodev-linux/${pname}.tar.gz";
sha256 = "0xhkhcdlds9aiz0hams93dv0zkgcn2abaiagdjlqdck7zglvvyk7";
url = "http://nwl.cc/pub/cryptodev-linux/${pname}.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use urls here, in case the other site comes back online.

@NeQuissimus NeQuissimus merged commit 907fa51 into NixOS:master Jul 24, 2017
@NeQuissimus NeQuissimus deleted the cryptodev_1_9 branch July 24, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeQuissimus @mention-bot @joachifm