Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module auditd: break ordering cycle on basic.target/start #11864 #27577

Merged
merged 1 commit into from Aug 1, 2017
Merged

module auditd: break ordering cycle on basic.target/start #11864 #27577

merged 1 commit into from Aug 1, 2017

Conversation

calbrecht
Copy link
Member

@calbrecht calbrecht commented Jul 23, 2017 •
edited

auditd creates an ordering cycle by adding wantedBy = [ "basic.target" ],
because of this the job job systemd-update-utmp.service/start is deleted.

adding unitConfig.DefaultDependencies = false; to the auditd service breaks the cycle.

Motivation for this change
Things done

Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@calbrecht
module auditd: unbreak ordering cycle on basic.target/start NixOS#11864
056354b 
auditd creates an ordering cycle by adding wantedBy = [ "basic.target" ],
because of this the job job systemd-update-utmp.service/start is deleted.

adding unitConfig.DefaultDependencies = false; to the auditd service unbreaks the cycle.
@calbrecht calbrecht changed the title module auditd: unbreak ordering cycle on basic.target/start #11864 module auditd: break ordering cycle on basic.target/start #11864 Jul 23, 2017
@joachifm joachifm merged commit 9396587 into NixOS:master Aug 1, 2017
@globin globin deleted the upstream-auditd-11864 branch August 1, 2017 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calbrecht @joachifm