programs.thefuck: support shells that don't use /etc/profile
#27578
+11
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The alias for
thefuck
is placed in/etc/profile
. However shell emulators likezsh
orfish
don't use these scripts due to known incompatibilities withbash
.Therefore an optional expression which detects which shells are enable in NixOS is needed which configures the alias in all needed shell envs.
I confirmed the change using an expression like this:
When booting into this generated VM (built with
nixos-build-vms
)zsh
works fine when runningfuck
on the CLI without complaining about missing aliases.After that I confirmed that the alias is only in the env scripts for bash and zsh (
/etc/static/zshenv
) by runninggrep -R 'fuck' /etc
.Things done
Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)