virtualbox: 5.1.22 -> 5.1.24 #27596
Merged
virtualbox: 5.1.22 -> 5.1.24 #27596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NeQuissimus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bachp and @dezgeg to be potential reviewers. |
aszlig
requested changes
Jul 23, 2017
| @@ -63,8 +63,6 @@ stdenv.mkDerivation { | |||
| do | |||
| cd $i | |||
| # Files within the guest additions ISO are using DOS line endings | |||
There was a problem hiding this comment.
Probably would make sense to remove this comment as well, because it would otherwise be quite confusing.
NeQuissimus
force-pushed
the
virtualbox_5_1_24
branch
from
6933d6c
to
ee6edb8
Compare
NeQuissimus
added
8.has: package (update)
and removed
2.status: work-in-progress
labels
aszlig
approved these changes
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
Things done
I keep running into #24256 (my user env is extremely messy right now), so I have not run this change.
Edit: Cleaned up my user env, build works and application seems to run (tested against minikube)
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)