WIP nix-shell: Use bashInteractive from <nixpkgs> #1483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds about 0.1s to nix-shell runtime in the case where bashInteractive already exists. See discussion at NixOS/nixpkgs#27493. Backport of 57a30e1
Ericson2314
commented
Jul 23, 2017
| } | ||
| chomp $buildShell; | ||
| $buildShell += "/bin/bash"; | ||
| if (! -x $buildShell) { |
There was a problem hiding this comment.
That is actually an executable test. Not sure which is better.
copumpkin
added a commit
to copumpkin/nixpkgs
that referenced
this pull request
Jul 24, 2017
It's better than the eval solution this is adding back, but until we can rely on a particular version of bash in nix-shell, this just breaks too much stuff. See NixOS/nix@c94f3d5 and NixOS/nix#1483 for the better long-term solution.
|
Probably not going to be merged now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of c94f3d5. Hopefully the extra dependency is no big deal--it is supposed to be minimal and Perl is going away soon anyways.
Don't merge yet because I still need to test.
CC @domenkozar