mailutils: 2.2 -> 3.2 #27595
mailutils: 2.2 -> 3.2 #27595
Conversation
|
Some tests fail on my system: Do they require dns resolving perhaps? |
|
I have checked that the tests pass even without internet. (However, they depend on the system state: I had to include a patch for the test that reads |
|
Here is the failing testcase: https://dl.thalheim.io/Z_TTsDyj594E0QzDXlR7LA/testsuite.log |
|
Tests fail with the message |
| mv readmsg/tests/*-$f readmsg/tests/$f | ||
| done | ||
| # Disable comsat tests that fail without tty in the sandbox. | ||
| tty -s || echo > comsat/tests/testsuite.at |
There was a problem hiding this comment.
Would it be possible to use script here so we can run the tests?
There are several tasks for which I use something like the following:
# shell quote the given arguments.
function quote {
# quote each argument, interposing a space each time
local quoted="$(printf "%q " "$@")"
# nuke the trailing space
quoted="${quoted%?}"
printf "%s" "$quoted"
}
# use `script` to run the given command under a new tty.
function faketty {
if [[ "$(uname)" == "Darwin" ]]; then
script -q /dev/null "$@"
else
script -qefc "$(quote "$@")" /dev/null
fi
}Dunno if it's worth it or not for these tests.
There was a problem hiding this comment.
... unless the problem is that a pty can't be allocated in our sandbox :).
There was a problem hiding this comment.
I believe this would work, thank you for sharing this! However, I do not plan to update mailutils definition soon.
Motivation for this change
This is a simpler alternative to #27580.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)