python: Don't link python3 executables if they don't exist #28230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that if python is built without pip we don't try to link pip3 -> pip
|
@seppeljordan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @domenkozar and @kragniz to be potential reviewers. |
|
Thanks, but I already pushed fixes to staging. E.g. 748589b |
|
@FRidh This prevents me from building a python environment with pip inside it. I would very much like your fixed to be part of master soon. Is there a way to help and accelerate this process? |
|
@seppeljordan no, you cannot. As soon as staging is sufficiently "stable", it will be merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that if python is built without pip we don't try to link pip3 -> pip
Motivation for this change
Currently it is not possible to create a python 3 environment with pip package in it, because there is a dead symlink in the deriviation of python3.x called $out/bin/pip which prevents building said environment.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)