ncurses: put tic binary in bin #28226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@casey, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @vcunat and @edolstra to be potential reviewers. |
|
I looked at the travis output, and it looks like it's just stalled because it's triggering a huge rebuild. |
|
Can you change the target branch from |
casey
requested review from
copumpkin,
Ericson2314,
FRidh and
LnL7
as code owners
|
Done, rebased and changed base branch to |
|
Also, for future PRs, when should I target master and when staging? |
|
@casey staging is for builds that trigger a lot of rebuilds. |
fpletz
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ticbinary wasn't being exported from the ncurses package.ticis the terminfo compiler, needed if one wants to compile new entries for the terminfo datbase.Tested by compiling a new terminfo entry and confirming that it worked.