Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixxx: fix build #28210

Merged
merged 1 commit into from
Aug 13, 2017
Merged

mixxx: fix build #28210

merged 1 commit into from
Aug 13, 2017

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Aug 12, 2017 •
edited

Motivation for this change

fixes #27763

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@magnetophon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cillianderoiste, @aszlig and @edolstra to be potential reviewers.

@magnetophon magnetophon mentioned this pull request Aug 12, 2017
Closed
@FRidh FRidh merged commit 651236d into NixOS:master Aug 13, 2017
@magnetophon magnetophon deleted the mixxx branch August 13, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mixxx does not build on unstable after an upgrade
3 participants
@magnetophon @mention-bot @FRidh