Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portaudio: 19-20140130 -> 190600-20161030, add jack #28219

Merged
merged 1 commit into from
Aug 15, 2017

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Aug 13, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@magnetophon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @lovek323 and @matthewbauer to be potential reviewers.

@fpletz
Copy link
Member

fpletz commented Aug 15, 2017

The failing package on Travis was broken before.

@fpletz fpletz merged commit a8fefd4 into NixOS:master Aug 15, 2017
@magnetophon magnetophon deleted the portaudio branch August 16, 2017 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants