Correctly work __has_colors check in bin/crystal #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Jul 27, 2017
makenowjust
changed the title
|
@ysbaddaden could you merge (or review) this? |
|
Merging, even though I have no idea how it works. |
|
Thank you @ysbaddaden |
|
@ysbaddaden bash I might be wrong though, my bash is a little rusty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shows
Using compiled compiler at `.build/crystal'with colors even thoughTERM=dumb ./bin/crystal(dumbis a name which is one of the terminal names not to support colors.), so this is buggy.In fact, this bug was pinpointed in #4499. I believe this is merged quickly.