CB-244: Frontend for the rating system #138

breakbuidl · 2017-07-27T07:31:31Z

Basic functionality for different types of review is up and running. Styling along with some other minor changes are to be done.

gentlecat

Rating selection doesn't show up for me for some reason.

gentlecat · 2017-07-29T19:13:58Z

critiquebrainz/frontend/forms/review.py

+        self.message = message
+
+    def __call__(self, form, field):
+        if not field.data and not form.rating.data:


Accessing other fields in a validator doesn't seem right. Form class uses a validate method which you can override and check that either text or rating are present. Make sure to call original method with super().validate().

gentlecat · 2017-07-29T19:18:25Z

critiquebrainz/frontend/templates/review/entity/base.html

@@ -124,3 +125,7 @@
  </div>
 </div>
 {% endblock %}
+
+{% block scripts %}
+  <script src="{{ get_static_path('scripts/rating1.js') }}" type="text/javascript"></script>


Is it supposed to be rating.js?

Yes, a typo.

gentlecat · 2017-07-29T19:21:07Z

critiquebrainz/frontend/templates/review/entity/base.html

@@ -124,3 +125,7 @@
  </div>
 </div>
 {% endblock %}
+
+{% block scripts %}


Make sure to call super() when defining a scripts block.

gentlecat · 2017-07-29T19:23:25Z

critiquebrainz/frontend/templates/review/modify/base.html

@@ -108,4 +114,5 @@
      });
    });
  </script>
+  <script src="{{ get_static_path('scripts/rating.js') }}" type="text/javascript"></script>


JS files shouldn't be accessed directly. The way we do it here now is by building JS files in gulpfile.js and referencing them like this: <script src="{{ get_static_path('rating.js') }}"></script>. That way you can easily use React, jQuery, etc. in your scripts.

Added ratingBundle in gulpfile.js

gentlecat · 2017-07-29T19:25:20Z

critiquebrainz/frontend/views/review.py

@@ -211,8 +214,10 @@ def create():
            return redirect(url_for('user.reviews', user_id=current_user.id))

        is_draft = form.state.data == 'draft'
+        if not form.text.data:


What values would these be?

TextAreaField in wtforms returns an empty string when no input is provided. So, it must be changed to None before inserted into the database.

Can you make a comment noting this? Or, even better, just compare to an empty string.

Same in another case below.

gentlecat · 2017-07-29T19:41:16Z

critiquebrainz/frontend/forms/review.py

@@ -16,7 +16,15 @@ def __call__(self, form, field):
        if form.state.data == "draft":
            return
        l = len(field.data) if field.data else 0
-        if l < self.min or self.max != -1 and l > self.max:
+        if (l < self.min or self.max != -1 and l > self.max) and (l != 0):


Can you explain what this change does? I even forgot how the original check works.

Originally it checked whether the length is between min and max and max is not -1. I added the check for not zero so that error is not raised when its empty. I am gonna remove it because the in- built Optional() validator works better.

gentlecat

Haven't tried using this yet, having some issues with Docker.

Is the rating code from some library or did you implement it yourself?

gentlecat · 2017-08-08T22:05:12Z

critiquebrainz/frontend/forms/review.py

+        if not super(ReviewEditForm, self).validate():
+            return False
+        if not self.text.data and not self.rating.data:
+            message = "Please provide at least one of text or rating for this review."


Does the message have to be in a separate variable?

The message isn't entirely grammatical. I suggest "Please provide some text or a rating for this review."

gentlecat · 2017-08-08T22:11:54Z

critiquebrainz/frontend/static/scripts/rating.js

@@ -0,0 +1,157 @@
+(function ($) {


Can you explain why this is necessary here? Sorry, I'm not that good at JS.

It provides closure.

gentlecat · 2017-08-08T22:20:32Z

critiquebrainz/frontend/static/scripts/rating.js

+(function ($) {
+  'use strict';
+
+  var clearClass = 'rating-clear',


I think it's just let by default now unless var is actually needed.

Since there's a closure, so the global environment won't be polluted and the code has been taken from a plugin, I think its wise to let it be the way author wrote it.

Don't be afraid to modify a library code if it can be improved or adjusted for the way we use it. Not every library published on the internet is perfect. :)

gentlecat · 2017-08-08T22:21:45Z

critiquebrainz/frontend/static/scripts/rating.js

+    this.highlight($input.val());
+  };
+
+  Rating.VERSION = '0.4.0';


What's this version?

Its plugin version. I will remove it.

gentlecat · 2017-08-08T22:24:16Z

critiquebrainz/frontend/views/review.py


    user_all_reviews, review_count = db_review.list_reviews(user_id=review["user_id"], sort="random", exclude=[review["id"]])  # pylint: disable=unused-variable
    other_reviews = user_all_reviews[:3]
-    return render_template('review/entity/%s.html' % review["entity_type"], review=review, spotify_mappings=spotify_mappings, soundcloud_url=soundcloud_url, vote=vote, other_reviews=other_reviews)
+    rating_titles = {20: "Terrible", 40: "Bad", 60: "Average", 80: "Good", 100: "Extradordinary"}


These strings should be wrapped in gettext.

gentlecat · 2017-08-08T22:30:11Z

critiquebrainz/frontend/static/scripts/rating.js

+
+  Rating.DEFAULTS = DEFAULTS;
+
+  Rating.prototype = {


Would it make sense to use Classes here?

gentlecat · 2017-08-08T22:31:40Z

critiquebrainz/frontend/templates/review/entity/base.html

@@ -25,9 +25,17 @@
          {% endif %}
        </em>
      {% endif %}
+      <br>
+      <br>


It's better to use CSS instead of adding line breaks for spacing.

gentlecat

Just tried using it. Seems to be working.

A few issues I noticed so far:

There's now a weird margin before rating stars:
I don't think titles for ratings are necessary.
Stars should be displayed a bit more prominently (perhaps make them slightly larger).
It's unnecessary to display a language when review is rating-only.
In the editor it's unclear that rating is unnecessary or that review might just have a rating without text. This should be made a bit more clear. Perhaps add a note.

mwiencek · 2017-08-10T16:37:41Z

critiquebrainz/frontend/static/scripts/rating.js

@@ -0,0 +1,157 @@
+(function ($) {


I don't recommend forking external libraries, but I can't say much else without knowing to what extent you've modified this. Can you please link to the original source code?

If we fork this, the file must include a copyright and license attached.

Original source - https://github.com/javiertoledo/bootstrap-rating-input
I used this plugin because suited our needs the best with a few modifications. Can you please tell why are you skeptical of this kinda thing. And yes I will add the copyright.

There are lot of other options. Can you please have a look at this quite comprehensive list https://github.com/dandv/comparisons/blob/master/star-rating-widgets.md and let me know what you have in mind.

It's more code we have to test (the modifications we make) and maintain (we don't have a lot of resources).

If any bug fixes are made upstream, we have to manually merge them into our fork, instead of just bumping the version in package.json.

It doesn't look like you've made that many modifications: https://gist.github.com/mwiencek/838e5abd016ce6627c23ba47befe2d2d

You don't need to fork the code to modify DEFAULTS. You can mutate it externally through $.fn.rating.Constructor.DEFAULTS.

For the rest, why not just submit a patch upstream to support what you're doing? That way other people benefit, and we don't have to maintain our own fork.

That's just my opinion, but I don't have much stake in this. :) Fork the code if you think that's a good idea.

If it's possible to just make it a dependency and modify defaults externally, I'd also prefer to do that.

I am trying do that and also looking for some other plugin which might be more suitable.

There's less than a week left for the official GSoC coding period, so I'd suggest to avoid doing very time consuming tasks such as evaluating different libraries. If this one works well enough then the only thing we need to do is clean up the code to meet our requirements and move on.

Yes, I decided for this plugin after a lot of searching and still didn't find any other which is more suitable. I have updated the package file and working on the required changes. Will let you know at the earliest if I face any problems.

breakbuidl · 2017-08-14T12:50:29Z

Understood. Will make proper commits from now on.

gentlecat

It looks like there's a conflict in the package.json file. This should be rebased on top of the latest commit in master.

gentlecat · 2017-08-17T11:48:29Z

critiquebrainz/frontend/static/scripts/rating.js

+  $('.glyphicon-remove-circle').hover(function() {
+    $(this).css('color', 'red');
+    }, function() {
+    $(this).css('color', '#808080');


Why not do this in the style definitions (Less files) that we already have?

Should this go in main.less or theme/glyphicons.less?

Stuff in theme shouldn't really be modified, so I'd say main.less.

breakbuidl · 2017-08-18T11:57:34Z

Please don't mind the merge and conflicts commits. Ran into some trouble.
Also, I can't resolve PyLint R0912 (too many branches). The functions which have this warning are quite large.

gentlecat · 2017-08-18T18:56:23Z

The functions which have this warning are quite large.

Well, that's not good. One way to fix this would be to extract some of the operations that are done in them into separate functions.

gentlecat · 2017-08-19T00:19:31Z

You can also add an ignore for this check on the functions and add a TODO comment saying that it needs improvement.

gentlecat

I get this exception when I open a homepage when there's a review without text:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/werkzeug/wsgi.py", line 660, in __call__
    return app(environ, start_response)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1997, in __call__
    return self.wsgi_app(environ, start_response)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1985, in wsgi_app
    response = self.handle_exception(e)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1540, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/code/critiquebrainz/frontend/views/index.py", line 19, in index
    preview = markdown(review['text'], safe_mode="escape")
  File "/usr/local/lib/python3.6/site-packages/markdown/__init__.py", line 494, in markdown
    return md.convert(text)
  File "/usr/local/lib/python3.6/site-packages/markdown/__init__.py", line 355, in convert
    if not source.strip():
AttributeError: 'NoneType' object has no attribute 'strip'

gentlecat · 2017-08-19T23:07:32Z

Another one:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/werkzeug/wsgi.py", line 660, in __call__
    return app(environ, start_response)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1997, in __call__
    return self.wsgi_app(environ, start_response)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1985, in wsgi_app
    response = self.handle_exception(e)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1540, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python3.6/site-packages/flask_login/utils.py", line 228, in decorated_view
    return func(*args, **kwargs)
  File "/code/critiquebrainz/frontend/views/review.py", line 304, in edit
    form.rating.data = review["rating"] // 20
TypeError: unsupported operand type(s) for //: 'NoneType' and 'int'

gentlecat · 2017-08-19T23:13:58Z

I can create a review with 0 stars. Is it possible to do that in the MusicBrainz UI?

breakbuidl · 2017-08-20T08:39:39Z

I get this exception when I open a homepage when there's a review without text:

Can you please check if you have included changes from #147 and the cache is clear? Because it works perfectly fine for me.

breakbuidl · 2017-08-20T09:07:15Z

Another one:

Resolved this

I can create a review with 0 stars. Is it possible to do that in the MusicBrainz UI?

No, one cannot rate 0 with MusicBrainz UI. And, creating a review with 0 stars is equal to 'Not rated'. So, rating will be NULL in this case.

gentlecat · 2017-08-20T18:01:52Z

Can you please check if you have included changes from #147 and the cache is clear? Because it works perfectly fine for me.

OK, seems to be working with latest changes now. But it might still be worth checking if there's any text before trying to convert it.

gentlecat

Looks a lot better now, good job. There are a few things that need to be cleaned up.

gentlecat · 2017-08-20T18:05:23Z

critiquebrainz/frontend/templates/event/entity.html

+        <i class="glyphicon glyphicon-star"></i>
+        <span style="font-size: 16px;">{{ avg_rating.rating }}</span><em class="text-muted">/5 based on {{ avg_rating.count }} ratings</em>
+      </p>
+    {% endif %}


It looks like this part is the same among all templates. It would be a good idea to make it a macro.

gentlecat · 2017-08-20T18:06:56Z

critiquebrainz/frontend/views/place.py

+        avg_rating = db_avg_rating.get(place['id'], "place")
+        avg_rating["rating"] = round(avg_rating["rating"] / 20, 1)
+    except db_exceptions.NoDataFoundException:
+        avg_rating = None


This part of code is also almost the same among different views. Can it be moved into one function that does average rating retrieval?

Added views/avg_rating for this purpose.

gentlecat · 2017-08-20T18:13:18Z

critiquebrainz/frontend/views/review.py

@@ -58,6 +59,8 @@ def browse():
                           page=page, limit=limit, count=count, entity_type=entity_type)


+# TODO : Refactor this function to remove PyLint warning.


In CB code we put an identifier next to a TODO comment to know who to ask if more details are needed. So something like

# TODO(psolanki): Refactor this function to remove PyLint warning.

Same in the comment below.

Will keep this in mind next time.

gentlecat · 2017-08-20T18:15:24Z

critiquebrainz/frontend/views/review.py


    user_all_reviews, review_count = db_review.list_reviews(  # pylint: disable=unused-variable
        user_id=review["user_id"],
        sort="random",
        exclude=[review["id"]],
    )
    other_reviews = user_all_reviews[:3]
+    if review["rating"] is not None:
+        review["rating"] //= 20


Can this conversion be done within the db package? That way users of these functions don't have to worry about converting the values, they'd just use 1-5 scale.

I'm still interested in a fix for this. Conversion from 5-star to 100 should be done within the db package. Modules that use it don't need to know about how ratings are stored. It's about making the interface less complex and easier to use.

I have proposed these changes - javiertoledo/bootstrap-rating-input#61
If this gets merged then there won't be any need for converting ratings to different scales anywhere.

That's great, but this is what we have now and the interface is not very well designed.

gentlecat · 2017-08-20T18:18:18Z

critiquebrainz/frontend/templates/review/entity/base.html

+        </div>
+      {% endif %}
+      {% if review.text %}
+        <!-- Used to display only-text review properly -->


What is used? Not sure if I understand what issue you are trying to solve there.

It is used for proper spacing above text when star icons are not present.

OK, but this should be simplified in the future.

gentlecat · 2017-08-20T18:28:52Z

Please don't mind the merge and conflicts commits. Ran into some trouble.

You can use git rebase -i origin/master on your branch to sync the changes quicker and cleaner. Let us know if you have any questions about that.

gentlecat · 2017-08-21T15:36:51Z

critiquebrainz/frontend/templates/place/entity.html

@@ -93,10 +94,8 @@ <h4 style="margin-bottom:0;">{{ _('Reviews') }}</h4>
  <div class="col-md-3">
    <h4>{{ _('Place information') }}</h4>
      {% if avg_rating %}


This checking can also be moved inside the show_avg_rating macro. And simply pass avg_rating to it. Make usage as simple as possible.

gentlecat · 2017-08-21T15:42:41Z

critiquebrainz/frontend/views/avg_rating.py

+import critiquebrainz.db.avg_rating as db_avg_rating
+import critiquebrainz.db.exceptions as db_exceptions
+
+def get(entity_id, entity_type):


It would probably be better to just put this into __init__.py of the frontend.views package instead of creating a new module just for one utility function. I think it's expected that modules in views contain actual views.

Move the function to __init__.py

gentlecat · 2017-08-21T15:47:34Z

critiquebrainz/frontend/views/review.py


    user_all_reviews, review_count = db_review.list_reviews(  # pylint: disable=unused-variable
        user_id=review["user_id"],
        sort="random",
        exclude=[review["id"]],
    )
    other_reviews = user_all_reviews[:3]
+    if review["rating"] is not None:
+        review["rating"] //= 20


I'm still interested in a fix for this. Conversion from 5-star to 100 should be done within the db package. Modules that use it don't need to know about how ratings are stored. It's about making the interface less complex and easier to use.

gentlecat · 2017-08-21T15:49:08Z

critiquebrainz/frontend/templates/review/modify/base.html

  <form id="review-editor" method="POST" class="form-horizontal" role="form">
    {{ form.hidden_tag() }}
    <div class="form-group">
+      <label class="col-sm-2" for="rating">{{ _('Rating for the review:') }}</label>


for the review part can be removed since it's pretty obvious what the rating is for.

Removed it and changed the column grid accordingly.

gentlecat · 2017-08-21T15:50:01Z

critiquebrainz/frontend/templates/review/entity/base.html

+        </div>
+      {% endif %}
+      {% if review.text %}
+        <!-- Used to display only-text review properly -->


OK, but this should be simplified in the future.

gentlecat · 2017-08-21T15:50:56Z

critiquebrainz/frontend/templates/place/entity.html

@@ -92,6 +93,11 @@ <h4 style="margin-bottom:0;">{{ _('Reviews') }}</h4>

  <div class="col-md-3">
    <h4>{{ _('Place information') }}</h4>
+      {% if avg_rating %}
+        <p>


What is the <p> for here?

It is needed to maintain the spacing format.

You should use CSS for this.

IMO, CSS isn't necessary here. Other elements in this column (in event and release_group) also use <p>, so we get perfectly formatted column without any use of CSS and by using mere <p>.

There are plenty of places that are not implemented correctly. The goal is to make the code better, not to keep using bad practices. When other code has been written it wasn't reviewed properly.

<p> is supposed to represent a paragraph of text, which doesn't seem to apply here.

gentlecat · 2017-08-21T15:51:51Z

critiquebrainz/frontend/templates/macros.html

+
+{% macro show_avg_rating(rating, count) %}
+  <i class="glyphicon glyphicon-star"></i>
+  <span style="font-size: 16px;">{{ rating }}</span><em class="text-muted">/5 {{ _('based on') }} {{ count }} {{ _('ratings') }}</em>


Split long lines, if necessary:

<span style="font-size: 16px;">{{ rating }}</span> <em class="text-muted">/5 {{ _('based on') }} {{ count }} {{ _('ratings') }}</em>

Its intentional. Splitting them will create an extra space.

gentlecat · 2017-08-21T15:56:00Z

critiquebrainz/frontend/templates/macros.html

+
+{% macro show_avg_rating(rating, count) %}
+  <i class="glyphicon glyphicon-star"></i>
+  <span style="font-size: 16px;">{{ rating }}</span><em class="text-muted">/5 {{ _('based on') }} {{ count }} {{ _('ratings') }}</em>


{{ _('based on') }} {{ count }} {{ _('ratings') }} should be combined into one localisable string. It can be a bad idea that the order of words would be the same in all languages.

_('based on %(number)s ratings', number=count)

Combined into one.

breakbuidl · 2017-08-29T21:10:06Z

There are 4 new commits containing the requested changes and 4 commits at the base are part of db/rating_scale.

- Properly display text-only reviews - Display rating stars on both sides when revisions are compared

…ntity_types

…g_rating.py

gentlecat · 2017-09-03T18:15:38Z

critiquebrainz/frontend/templates/review/entity/base.html

+               {{ _('<a href="%(link)s">Sign in</a> to rate this review', link=url_for('login.index', next=url_for('review.entity', id=review.id))) }}
+              </div>
+            {% else %}
+              <div class="col-md-5"></div>


Why keep this duplicate block definition around? It might be better to just move the condition inside it.

gentlecat · 2017-09-03T18:18:46Z

critiquebrainz/frontend/views/__init__.py

+import critiquebrainz.db.exceptions as db_exceptions
+
+def get_avg_rating(entity_id, entity_type):
+    """Retrieve avg_rating and convert rating on a scale 1-5."""


What's avg_rating? Average rating? There's no need to literally use variable names in docstrings.

gentlecat · 2017-09-03T18:19:14Z

critiquebrainz/frontend/views/__init__.py

+    except db_exceptions.NoDataFoundException:
+        avg_rating = None
+
+    return avg_rating


Instead of assigning a variable why not just directly return values?

breakbuidl force-pushed the cb-244/frontend branch from 2208d52 to f630408 Compare July 28, 2017 16:33

gentlecat self-requested a review July 29, 2017 16:18

gentlecat suggested changes Jul 29, 2017

View reviewed changes

breakbuidl force-pushed the cb-244/frontend branch 2 times, most recently from 9071c6d to 61f3c09 Compare August 7, 2017 22:15

gentlecat suggested changes Aug 8, 2017

View reviewed changes

gentlecat suggested changes Aug 10, 2017

View reviewed changes

mwiencek reviewed Aug 10, 2017

View reviewed changes

gentlecat suggested changes Aug 17, 2017

View reviewed changes

breakbuidl force-pushed the cb-244/frontend branch 3 times, most recently from 6093314 to f44e56b Compare August 19, 2017 08:28

gentlecat suggested changes Aug 19, 2017

View reviewed changes

gentlecat suggested changes Aug 20, 2017

View reviewed changes

gentlecat suggested changes Aug 21, 2017

View reviewed changes

breakbuidl force-pushed the cb-244/frontend branch from 58a731c to 9530fc1 Compare August 29, 2017 20:56

breakbuidl force-pushed the cb-244/frontend branch from 9530fc1 to 7c0b937 Compare August 29, 2017 21:20

gentlecat added the blocked by another PR label Sep 3, 2017

gentlecat changed the title ~~CB-244: Rating system (Frontend)~~ CB-244: Frontend for the rating system Sep 3, 2017

Pinank Solanki added 21 commits September 3, 2017 23:26

Convert ratings to values on a scale 0-100

84fb88a

Adjust star icons on review page

59810e4

Change styling of rating icons to main.less from rating.js

6b29fea

Remove voting feature for rating-only reviews

67f4f9c

Display avg rating on review entity page

e9abca9

Display average rating on entity page

d3bcfdf

Resolve Pylint warnings

37739be

Resolve Pylint warnings

932f624

Minor fixes

95e7d7c

Ignore PyLint warning R0912 (too many branches)

7117d17

Resolve form.rating.data value error in edit

d417d8c

Remove useful votes display for rating-only review

e2020a6

UI improvements

aff63e7

- Properly display text-only reviews - Display rating stars on both sides when revisions are compared

Add macro show_avg_rating

02d736b

Assign TODO to psolanki

2467a2f

Add views/avg_rating and relevant changes in views/review and views/e…

8e78998

…ntity_types

Move avg_rating retrieval function to views/__init__.py from views/av…

8477295

…g_rating.py

Remove rating scale conversions from frontend

be9af6c

Remove 'for the rating' part on write review page

ed7d321

Combine strings into one in avg_rating macro

1d4f7c9

Change rating DEFAULTS empty-value to null

0b262fa

breakbuidl force-pushed the cb-244/frontend branch from edce61f to 0b262fa Compare September 3, 2017 17:58

gentlecat suggested changes Sep 3, 2017

View reviewed changes

Resolve PyLint warnings

9d711bf

breakbuidl force-pushed the cb-244/frontend branch from 1ccb775 to 9d711bf Compare September 3, 2017 18:21

Pinank Solanki added 3 commits September 4, 2017 00:53

Remove unnecessary variable and update docstring

9127e0b

Code clean up

279493d

Use div and add class avg-rating for better semantics

df51832

gentlecat approved these changes Sep 5, 2017

View reviewed changes

gentlecat merged commit 078cbc2 into metabrainz:master Sep 5, 2017

		@@ -58,6 +59,8 @@ def browse():
		page=page, limit=limit, count=count, entity_type=entity_type)


		# TODO : Refactor this function to remove PyLint warning.

CB-244: Frontend for the rating system #138

CB-244: Frontend for the rating system #138

Conversation

breakbuidl commented Jul 27, 2017

gentlecat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentlecat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentlecat left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

breakbuidl Aug 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

breakbuidl commented Aug 14, 2017

gentlecat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

breakbuidl commented Aug 18, 2017 • edited

gentlecat commented Aug 18, 2017

gentlecat commented Aug 19, 2017

gentlecat left a comment

Choose a reason for hiding this comment

gentlecat commented Aug 19, 2017

gentlecat commented Aug 19, 2017

breakbuidl commented Aug 20, 2017 • edited

breakbuidl commented Aug 20, 2017 • edited

gentlecat commented Aug 20, 2017

gentlecat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentlecat Aug 21, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

breakbuidl Aug 21, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentlecat commented Aug 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentlecat left a comment •

edited

breakbuidl Aug 10, 2017 •

edited

breakbuidl commented Aug 18, 2017 •

edited

breakbuidl commented Aug 20, 2017 •

edited

breakbuidl commented Aug 20, 2017 •

edited

gentlecat Aug 21, 2017 •

edited

breakbuidl Aug 21, 2017 •

edited

breakbuidl Aug 29, 2017 •

edited

breakbuidl Sep 3, 2017 •

edited