Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix taskwarrior fish completions #28307

Merged
merged 1 commit into from
Aug 26, 2017

Conversation

jonafato
Copy link
Contributor

Fish expects third party completions to be in a directory called
vendor_completions.d rather than completions.

Motivation for this change

taskwarrior's fish completions don't work.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Fish expects third party completions to be in a directory called
`vendor_completions.d` rather than `completions`.
@Mic92 Mic92 merged commit 09a6ed7 into NixOS:master Aug 26, 2017
@Mic92
Copy link
Member

Mic92 commented Aug 26, 2017

Thanks!

@jonafato jonafato deleted the fix-taskwarrior-completions branch August 26, 2017 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants