networkmanager_iodine: init at 1.2.0 #28305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@symphorien, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @lethalman and @rickynils to be potential reviewers. |
joachifm
reviewed
Aug 20, 2017
nixos/modules/misc/ids.nix
Outdated
| @@ -297,6 +297,7 @@ | |||
| clickhouse = 278; | |||
| rslsync = 279; | |||
| minio = 280; | |||
| nm-iodine = 281; | |||
There was a problem hiding this comment.
Why does it need a static uid?
There was a problem hiding this comment.
Honnestly, I just duplicated the code for the nm-openvpn module.
There was a problem hiding this comment.
If there is no reason to use a static uid, please consider using a dynamic uid instead.
There was a problem hiding this comment.
that was indeed unneeded. I fixed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
make the nm-iodine plugin available on nixos
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)