Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sublime3: fix package re-zipping #28303

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Conversation

chris-martin
Copy link
Contributor

Motivation for this change

The previous zip command wasn't including directories. This Sublime package only has one directory in it, so the resulting bug was subtle. The directory contained the send2trash Python package, so the result was that file deletion didn't work.

This diff also includes a few minor shufflings-around to make the Nix package slightly easier to debug.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The previous zip command wasn't including directories. This Sublime package only
has one directory in it, so the resulting bug was subtle. The directory
contained the send2trash Python package, so the result was that file deletion
didn't work.
@Mic92 Mic92 merged commit 34d8ff1 into NixOS:master Aug 16, 2017
@chris-martin chris-martin deleted the pr/sublime3-zip-fix branch August 16, 2017 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants