ostree: 2016.11 -> 2017.9 #27728
Merged
ostree: 2016.11 -> 2017.9 #27728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@konimex, thanks for your PR! By analyzing the history of the files in this pull request, we identified @copumpkin to be a potential reviewer. |
|
Have you tested this or just built it? |
|
(Re: "more testing may be needed") |
|
Actually, I have no idea how to test this, but it bulids just fine. Also, closing this one -- maybe someone will open up a better PR/commit. |
|
It looks fine to me, but I don't use OSTree anymore so I can't really test it meaningfully. Unless you have reason to believe that it'll cause issues, I'd just bump the version. Any objections to me just merging? |
|
(I have no objections) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Self-explanatory.
Pinging @copumpkin, maintainer of this package. More testing may be needed.
Things done
Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)