alacritty: Don't use xclip from PATH #27818
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NeQuissimus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92 and @puffnfresh to be potential reviewers. |
puffnfresh
approved these changes
Jul 31, 2017
puffnfresh
approved these changes
Jul 31, 2017
| @@ -47,6 +47,11 @@ buildRustPackage rec { | |||
| pkgconfig | |||
There was a problem hiding this comment.
We can probably remove xclip from buildInputs. I don't think it's used at build time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tried to use alacritty. Copy/paste was not working since it looks on the PATH.
This patches the code to look at the buildInput xclip.
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)@Mic92 @puffnfresh