Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rescue IO errors from input.close in HTTP request processor #4768

Merged
merged 1 commit into from Aug 1, 2017
Merged

Rescue IO errors from input.close in HTTP request processor #4768

merged 1 commit into from Aug 1, 2017

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented Jul 31, 2017

Closing the request IO calls IO#flush, which often can raise EPIPE or ECONNRESET
errors, causing erroneous logging in HTTP servers.

@RX14
Rescue IO errors from input.close in HTTP request processor
6166aa7 
Closing the request IO calls IO#flush, which often can raise EPIPE or ECONNRESET
errors, causing erroneous logging in HTTP servers.
@RX14 RX14 merged commit 919cba9 into crystal-lang:master Aug 1, 2017
@RX14 RX14 added this to the Next milestone Aug 1, 2017
@makenowjust makenowjust mentioned this pull request Aug 9, 2017
Merged
straight-shoota pushed a commit to straight-shoota/crystal that referenced this pull request Aug 11, 2017
@RX14 @straight-shoota
Rescue IO errors from input.close in HTTP request processor (crystal-…
8d5a213 
…lang#4768)

Closing the request IO calls IO#flush, which often can raise EPIPE or ECONNRESET
errors, causing erroneous logging in HTTP servers.
Val pushed a commit to Val/crystal that referenced this pull request Aug 12, 2017
@RX14 @Val
Rescue IO errors from input.close in HTTP request processor (crystal-…
a52dc0d 
…lang#4768)

Closing the request IO calls IO#flush, which often can raise EPIPE or ECONNRESET
errors, causing erroneous logging in HTTP servers.
@n7olkachev n7olkachev mentioned this pull request Sep 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RX14 @jhass