radicale: update to version 2 #27826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
changed the title
|
Pinging @aneeshusa @edwtjo and @pSub as they are in the maintainers list. |
infinisil
changed the title
infinisil
force-pushed
the
radicale
branch
3 times, most recently
from
9c87e5c
to
3ea1426
Compare
This commit readds and updates the 1.x package from 1.1.4 to 1.1.6 which also includes the needed command for migrating to 2.x The module is adjusted to the version change, defaulting to radicale2 if stateVersion >= 17.09 and radicale1 otherwise. It also now uses ExecStart instead of the script service attribute. Some missing dots at the end of sentences were also added. I added a paragraph in the release notes on how to update to a newer version.
|
Thanks! |
8 tasks
This was referenced Nov 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It has been long overdue for a radicale update, this PR does that. I also modified the test to work, it seemed to be disabled for not working.
ToDoDone: Backwards-compatibilityThe 2.x releases of radicale are NOT backwards compatible. There should be two derivations for
radicale1andradicale2, whileradicale = radicale2. To not mess with previously working radicale setups, there should be apackageoption for the radicale module, defaulting toradicale1ifsystemVersion <= 17.03andradicale2otherwise. Users can then manually upgrade to 2.x by settingpackage = radicale2, adjusting the config and following the official guide for migration. This should be added to the release notes.Edit: This has been done
Things done
I have been running this version for a few days now and haven't run into any problems.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)