Respect NIX_DONT_SET_RPATH when .so appears in the command line #27831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Unified processing of command line arguments in ld-wrapper broke support for `NIX_DONT_SET_RPATH` and revealed that ld-wrapper adds the directory of its `-plugin` argument to runpath. This pull request fixes that. It treats `dir/libname.so` as `-L dir -l name`, because this is how `ld.so` interprets resulting binary: with `dir` in `RUNPATH` and the bare `libname.so` (without `dir`) in `NEEDED`, it looks for `libname.so` in each `RUNPATH` and chooses the first, even when the linker was invoked with an absolute path to `.so`.
|
Fixed the bug and made it smaller, nice! |
orivej
added a commit
to orivej/nixpkgs
that referenced
this pull request
Aug 7, 2017
This fixes a bug introduced in NixOS#27831: `for path in "$dir"/lib*.so` assumed that all libs match `lib*.so`, but 0767478 started adding libs that match `*.so` and `*.so.*`.
orivej
added a commit
to orivej/nixpkgs
that referenced
this pull request
Aug 8, 2017
This fixes a bug introduced in NixOS#27831: `for path in "$dir"/lib*.so` assumed that all libs match `lib*.so`, but 0767478 started adding libs that match `*.so` and `*.so.*`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unified processing of command line arguments in ld-wrapper broke support for
NIX_DONT_SET_RPATHand revealed that ld-wrapper adds the directory of its-pluginargument to runpath. This pull request fixes that. It treatsdir/libname.soas-L dir -l name, because this is howld.sointerprets resulting binary: withdirinRUNPATHand the barelibname.so(withoutdir) inNEEDED, it looks forlibname.soin eachRUNPATHand chooses the first, even when the linker was invoked with an absolute path to.so.Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)