chromium: update to 60.0.3112.90 and add flags #27822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get rid of outdated version branches and patches take a patch from gentoo, to fix gn bootstrapping
|
NOPE there is a linker error due to |
This is lifted from the Arch build recipe: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/chromium using system libjpeg still doesn't work for some reason, otherwise the build runs fine
bendlas
force-pushed
the
update-chromium
branch
from
e814efa
to
88fa95f
Compare
|
Builds and runs now |
bendlas
changed the title
|
Updated to latest stable. Still builds and runs. Please merge and cherry-pick to stable |
This was referenced Aug 10, 2017
|
cc @aszlig |
|
I built this sucessfully |
|
I'm unsure about some of the changes and @aszlig knows more about this. |
|
@Ericson2314: Did you also run it and it went without errors in |
aszlig
approved these changes
Aug 11, 2017
|
Since this isn't backported to stable yet, and regarding the uncertainty about the altered flags: The commits are structured such that only the update commits ( |
|
@aszlig I have no idea; I was building it for someone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The update commit is the regular stable update + necessary patches.
The build flag commit takes the opportunity to get rid of cruft, to make chromium use a couple of more system dependencies (instead of building its own).
It also adds a couple of build flags, lifted from the arch recipe.
Things done
Build in progress, at about 90%, an iteration of this already worked. I'll check the boxes, when finished.
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)