axoloti: init at 1.0.12 #28328
Closed
axoloti: init at 1.0.12 #28328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why I am the author of this commit :) |
Mic92
reviewed
Aug 26, 2017
| @@ -5,19 +5,19 @@ | |||
| , gtk2, hunspell, icu, libevent, libjpeg, libnotify | |||
| , libstartup_notification, libvpx, makeWrapper, mesa | |||
| , nspr, nss, pango, perl, python, libpulseaudio, sqlite | |||
| , unzip, xlibs, which, yasm, zip, zlib | |||
| , unzip, xlibs, which, yasm, zip, zlib, gcc | |||
There was a problem hiding this comment.
Please make this a separate commit.
There was a problem hiding this comment.
indeed, this does not belong there, must be a merge issue since I didn't modify this myself -- will check
Mic92
reviewed
Aug 26, 2017
| @@ -60,7 +60,7 @@ in pythonPackages.buildPythonApplication rec { | |||
| owner = "foosel"; | |||
| repo = "OctoPrint"; | |||
| rev = version; | |||
| sha256 = "06l8khbq3waaaa4cqpv6056w1ziylkfgzlb28v30i1h234rlkknq"; | |||
| sha256 = "1hci8cfmbzcghla1vmrcn6zicm8nj50drm7gp2hkr0drglq5fgr2"; | |||
There was a problem hiding this comment.
Please make this a separate commit.
Mic92
reviewed
Aug 26, 2017
| @@ -4,7 +4,7 @@ | |||
| }: | |||
|
|
|||
| let | |||
| version = "4.3.0"; | |||
| version = "4.4.0"; | |||
There was a problem hiding this comment.
Please make this a separate commit.
Mic92
reviewed
Aug 26, 2017
| cp -r doc firmware chibios platform_linux CMSIS *.txt $out/share/axoloti/ | ||
| install -vD dist/Axoloti.jar $out/share/axoloti/ | ||
|
|
||
| cat > $out/bin/axoloti <<EOF |
There was a problem hiding this comment.
makeWrapper is preferred here, see https://nixos.org/nixpkgs/manual/#sec-language-java as an example
Mic92
approved these changes
Aug 26, 2017
|
@TealG are you still working on this? |
Mic92
reviewed
Oct 4, 2017
lib/maintainers.nix
Outdated
| @@ -590,6 +590,7 @@ | |||
| taku0 = "Takuo Yonezawa <mxxouy6x3m_github@tatapa.org>"; | |||
| tari = "Peter Marheine <peter@taricorp.net>"; | |||
| tavyc = "Octavian Cerna <octavian.cerna@gmail.com>"; | |||
| TealG = "Teal Gaure <~@Teal.Gr>" | |||
|
@Mic92 fixed |
|
Did you close the pr by accident? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)