Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin stdenv: Float persistentN bindings into per-stage lets #28322

Merged
merged 1 commit into from Aug 18, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Aug 16, 2017

Motivation for this change

This is a first step to formatting like the bootstrapping for other platforms.

Talked about on IRC, and @LnL7 and @copumpkin thought this was a good idea---but let's have one of you confirm before I merge.

Things done

The hash of the darwin stdenv is the same.


@Ericson2314 Ericson2314 requested a review from LnL7 August 16, 2017 20:40
@Ericson2314 Ericson2314 self-assigned this Aug 16, 2017
@Ericson2314 Ericson2314 modified the milestone: 17.09 Aug 16, 2017
Copy link
Member

@copumpkin copumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shape of it looks fine, and if the hash hasn't changed, there's not much of concern 😄

@Ericson2314 Ericson2314 merged commit b190c06 into NixOS:master Aug 18, 2017
@Ericson2314 Ericson2314 deleted the darwin-boot branch August 18, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants