Restore Chromium update in release-17.03, fix beta build #28170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Chromium is out of date in 17.03 release branch. Reverts reversion of updates and fixes beta build error.
I tested the beta (60) version which had the build error and it builds and seems to run fine. I didn't test the stable (59) version, presumably the submitter of the original update already tested that.
By the way, I don't think a build error in beta or stable warrants reverting updates as long as the stable version works. I would even question the need to maintain beta and dev builds considering the long build time; that triplicates the already huge time it takes to test before submitting a pull request.
/cc @globin
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)