Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Chromium update in release-17.03, fix beta build #28170

Merged
merged 2 commits into from Aug 26, 2017

Conversation

ambrop72
Copy link
Contributor

Motivation for this change

Chromium is out of date in 17.03 release branch. Reverts reversion of updates and fixes beta build error.

I tested the beta (60) version which had the build error and it builds and seems to run fine. I didn't test the stable (59) version, presumably the submitter of the original update already tested that.

By the way, I don't think a build error in beta or stable warrants reverting updates as long as the stable version works. I would even question the need to maintain beta and dev builds considering the long build time; that triplicates the already huge time it takes to test before submitting a pull request.

/cc @globin

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ambrop72
Copy link
Contributor Author

By the way, I don't think a build error in beta or stable warrants reverting updates

Oh I see the beta is the same as stable, so never mind that, yes this fixes the stable build and works for me.

@PierreR
Copy link
Contributor

PierreR commented Aug 22, 2017

@ambrop72 Any idea when google-stable will be available again in nixos-stable ? Is there a place where I can follow the process ? Hope a fix is going to be pushed on stable soon whatever it is ;-)

@joachifm joachifm merged commit e56d163 into NixOS:release-17.03 Aug 26, 2017
@joachifm
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants