gpy: init at 1.7.7 #28172
gpy: init at 1.7.7 #28172
Conversation
| sha256 = "1b4siirlkqic1lsn9bi9mnp8fpbpw1ijwv0z2i6r2zdrk3d6szs1"; | ||
| }; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Why are the tests disabled? Always include a comment explaining why.
There was a problem hiding this comment.
Never mind, something is still wrong.
bcdarwin
force-pushed
the
gpy
branch
2 times, most recently
from
1ade511
to
3c4403b
Compare
|
I've disabled the tests for now and added a comment regarding this. |
| description = "Gaussian process framework in Python"; | ||
| homepage = https://sheffieldml.github.io/GPy; | ||
| license = licenses.bsd3; | ||
| maintainers = with maintainers; [ bcdarwin ]; |
There was a problem hiding this comment.
We also need a platforms attribute here.
There was a problem hiding this comment.
Why? Do you want to exclude a certain platform? buildPythonPackage inherits platforms from python.
There was a problem hiding this comment.
Oh nevermind, didn't realize it was python.
| checkPhase = "nosetests -d"; | ||
| doCheck = false; | ||
|
|
||
| buildInputs = [ nose cython matplotlib ]; |
There was a problem hiding this comment.
could you move nose to checkInputs
There was a problem hiding this comment.
Done; I've also moved matplotlib to propagatedBuildInputs as it's both required for tests and by some gpy modules.
Motivation for this change
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)