Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns-root-data: 2017-07-11 -> 2017-07-26 #28178

Merged
merged 1 commit into from
Aug 14, 2017
Merged

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Aug 12, 2017

Motivation for this change

old version is no longer available

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -4,7 +4,7 @@ let

rootHints = fetchurl {
url = "http://www.internic.net/domain/named.root";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably something like that would be preferable in the future: https://github.com/Mic92/iana-etc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only change every few years. I think's that should be fine for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes of a root server IP happened a couple times during the last year. Next change is scheduled for October.

@joachifm
Copy link
Contributor

cc @fpletz

@fpletz fpletz merged commit 2a0c6c7 into NixOS:master Aug 14, 2017
@fpletz
Copy link
Member

fpletz commented Aug 14, 2017

Thanks!

@sigma sigma deleted the pr/dns-root-data branch October 1, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants