Removed networking.fqdn option #27798

regellosigkeitsaxiom · 2017-07-31T11:03:23Z

Adding it was a mistake which can only lead to problems and confusion.
A cleanup after #27105. See discussion with @edolstra in #27105 for details.

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Adding it was a mistake which can only lead to problems and confusion.

Ma27 · 2017-07-31T13:28:16Z

this change misses an entry in rename.nix which might lead to confusion if a build breaks

regellosigkeitsaxiom · 2017-07-31T14:53:29Z

@Ma27 something like this?

Option existed for only couple of days, I am not sure if it really needs to leave such traces.

edolstra · 2017-07-31T17:51:44Z

Indeed we don't have to provide backwards compatibility for options that only existed on master (regardless of the length of time).

Removed networking.fqdn option

500280f

Adding it was a mistake which can only lead to problems and confusion.

globin merged commit d30b2eb into NixOS:master Jul 31, 2017

Provide feedback