Added OptionParser#order and #order! #4809
Closed
+133
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougEverly
force-pushed
the
OptionParser_order
branch
from
a24e281 to
9cec58b
Compare
|
This PR seems to do a lot of rewriting, i'd rather not have a separate code path for this. Actually it seems like the optionparser needs a rewrite :( |
|
Personally I never was a big fan of the optionparser interface, so if we decide to rewrite maybe we also should look at other interfaces like slop, thor etc |
|
Closing. The code is outdated with the refactorings to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
#orderand#order!methods toOptionParser. Intent is to mimic Ruby's#orderargument processing such that processing is stops when first unknown arg is reach and remaining is returned as array.This enables subcommand processes as subcommand can be shifted off array and further processed with subsequent
#ordercalls on the array.