ghcjs / nodejs: Add back older 6.x node version for GHCJS #28017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlevy
reviewed
Aug 8, 2017
pkgs/top-level/all-packages.nix
Outdated
| @@ -2628,6 +2628,10 @@ with pkgs; | |||
| libtool = darwin.cctools; | |||
| }; | |||
|
|
|||
| nodejs-ghcjs = callPackage ../development/web/nodejs/v6-ghcjs.nix { | |||
There was a problem hiding this comment.
Can you add a comment linking to the relevant issues?
GHCJS seems to rely on it, otherwise the TH evaluator fails with an unexpectedly closed file descriptor. Node was bumped in 59249d0
Ericson2314
force-pushed
the
ghcjs-node-version
branch
from
8e0d41f
to
f551ab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
GHCJS seems to rely on it, otherwise the TH evaluator fails with an unexpectedly closed file descriptor. Not sure how unstable has dealt with this.
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)