Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.gst-python: Use correct package set #27805

Closed
wants to merge 1 commit into from
Closed

pythonPackages.gst-python: Use correct package set #27805

wants to merge 1 commit into from

Conversation

expipiplus1
Copy link
Contributor

Previously this was using pkgs.pythonPackages. This was leading to
a build with an incorrect version of python.

It might be worth having the pythonPackages = self attribute for
all pythonPackages instead of just specific packages as it is at the
moment.

This fixes packages which depend on the python3 version of gst-python
such as pitivi.

@expipiplus1
pythonPackages.gst-python: Use correct package set
2327298 
Previously this was using pkgs.pythonPackages. This was leading to
a build with an incorrect version of python.

It might be worth having the `pythonPackages = self` attribute for
all pythonPackages instead of just specific packages as it is at the
moment.

This fixes packages which depend on the python3 version of gst-python
such as pitivi.
@expipiplus1 expipiplus1 requested a review from FRidh as a code owner July 31, 2017 16:37
@FRidh
Copy link
Member

FRidh commented Jul 31, 2017

It might be worth having the pythonPackages = self attribute for
all pythonPackages instead of just specific packages as it is at the
moment.

Could you elaborate what you mean? Python libraries have the their requirements as individual parameters. Python applications, which are not called via python-packages.nix, have pythonPackages or python as parameter to make sure we do not mix Python libraries of different Python versions/package sets.

FRidh
FRidh reviewed Jul 31, 2017
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You best also set pythonPath = []; in the expression. Otherwise it won't be able to find the modules with python.buildEnv.

Also, because this is a Python library, it should be in pkgs/development/python-modules.

@expipiplus1
Copy link
Contributor Author

Could you elaborate what you mean?

I mean setting pythonPackages = self; as an attribute of self in python-packages.nix instead of an extra argument to callPackage as it's done in these places (and more):

https://github.com/expipiplus1/nixpkgs/blob/23272981863b0095765449f674b228376e1d1387/pkgs/top-level/python-packages.nix#L85
https://github.com/expipiplus1/nixpkgs/blob/23272981863b0095765449f674b228376e1d1387/pkgs/top-level/python-packages.nix#L224
https://github.com/expipiplus1/nixpkgs/blob/23272981863b0095765449f674b228376e1d1387/pkgs/top-level/python-packages.nix#L228

@expipiplus1
Copy link
Contributor Author

I think that those other changes might be more appropriate in another PR. This is just a small change to get things working a little better :)

@FRidh
Copy link
Member

FRidh commented Aug 13, 2017

pushed f913554 and d0d8724

@FRidh FRidh closed this Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@expipiplus1 @FRidh