Kdeconnect: add sshfs dependency and provide NixOS module #27806
Conversation
- Adds sshfs as runtime dependency with makeWrapper - Adds programs.kdeconnect to open required UDP/TCP ports
There was a problem hiding this comment.
Thanks for the PR. I am not in favor of merging these changes but will keep it open for feedback from others.
-
kdeconnectcan indeed usesshfsbut I don't think we should make this a required dependency as its not essential for its operation, its just for a certain feature. By installing the program yourself, it ends up on your path and it will function. Yet at the same time, its a tiny package that is added. -
Having a module is convenient as you just flip a switch and it will work. However, it is my understanding that modules are not intended for user applications but for system services. Furthermore, modules adding programs to
environment.systemPackagesis somewhat frowned upon as well, even though it is done so extensively in Nixpkgs. Document conventions around environment.systemPackages #12575
FRidh
changed the title
|
Should have tried to install sshfs before modifying the package. Sorry for that! Hmm, but isn't kdeconnectd a service? It's running in the background as daemon, for me that sounds like a service :D Yeah it would be more like a user service. My initial intention for this pr was that kdeconnect could not find my android device.Luckily I remembered that Nixos has a firewall and the ports for kdeconnect needs to be opened. This should at least be documented (required open ports and how). |
Indeed, and NixOS services are mostly system services. This might be something for #9250.
Having a service open ports on a firewall is also frowned upon, at least with its current implementation. Please read #19504. The idea of a firewall is to block everything by default unless configured otherwise.
The firewall is documented in the NixOS manual, https://nixos.org/nixos/manual/index.html#sec-firewall. If you need access to ports you should know that, which means knowing your application, and therefore it is the task of upstream to document that properly. Sure, it may definitely be helpful if we could communicate/suggest somehow that ports need to be opened. Maybe its an idea to use |
|
There has not been any other feedback so I am closing this. |
Motivation for this change
Kdeconnect requires sshfs for opening filesystem connections to android devices. The UDP/TCP ports are required that Kdeconnect can find other devices.
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)