Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark attribute to scroll_area_control #1843

Open
ghost opened this issue Jul 26, 2017 · 3 comments
Open

Add dark attribute to scroll_area_control #1843

ghost opened this issue Jul 26, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 26, 2017

Summary

Absolutely minor, but mini map control should be a child of the text_area_control.

Expected behavior

Next code should work:

  {
    "class": "minimap_control",
    "parents": [
      {
        "class": "text_area_control",
        "attributes": [
          "file_light"
        ]
      }
    ],
    "viewport_color": [
      0,
      0,
      0,
      1.0
    ]
  },

Actual behavior

Now it doesn't.

Steps to reproduce

  1. Open Adaptive.sublime-theme
  2. Add code from Expected behavior right after minimap_control styles.
  3. Open the tab with a color scheme which has "opposite" lightness level to your global color scheme.

Environment

  • Operating system and version:
    • Windows 7
  • Monitor:
    • 1920x1080
    • dpi_scale: 1.0
  • Sublime Text:
    • Build 3141
    • 64 bit
@wbond
Copy link
Member

wbond commented Jul 27, 2017

Technically the text_area_control and minimap_control are both contained by a scroll_area_control, but that doesn't get file_light, file_medium, file_dark, etc. It only has the the dark attribute (or absence of it).

@ghost
Copy link
Author

ghost commented Jul 27, 2017

Thanks! That's enough 🎉

@ghost ghost closed this as completed Jul 27, 2017
@ghost
Copy link
Author

ghost commented Jul 27, 2017

Just tested :( It seems that scroll_area_control doesn't have dark attribute, only scroll_bar_control, scroll_track_control and puck_control have it.

@ghost ghost reopened this Jul 27, 2017
@ghost ghost changed the title Mini map control should be a child of the text_area_control Add dark attribute to scroll_area_control Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant