Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python2-pythondialog: fix --replace on substituteInPlace; fixes certbot #27915

Merged
merged 1 commit into from Aug 4, 2017

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Aug 3, 2017

Motivation for this change

This fixes the package itself, as well as certbot

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bendlas bendlas requested a review from FRidh as a code owner August 3, 2017 20:42
@globin globin merged commit a37dd36 into NixOS:master Aug 4, 2017
@bendlas bendlas deleted the fix-certbot branch October 22, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants