Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packer: add missing go-dependency #27907

Merged
merged 1 commit into from
Aug 3, 2017
Merged

packer: add missing go-dependency #27907

merged 1 commit into from
Aug 3, 2017

Conversation

WilliButz
Copy link
Member

Motivation for this change

the missing dependency prevented a successful build

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@WilliButz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @cstrahan and @fpletz to be potential reviewers.

@globin globin merged commit aa8cbed into NixOS:master Aug 3, 2017
kamilchm
kamilchm reviewed Aug 8, 2017
View reviewed changes
Copy link
Member

@kamilchm kamilchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the old repo was transferred from github.com/mitchellh/packer to github.com/hashicorp/packer. We should change package src and goPackagePath to the new one instead of adding it in goDeps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm kamilchm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WilliButz @mention-bot @kamilchm @globin