Parser: allow trailing comma after named arguments in index notation #4784
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation Fix crystal-lang#4782 For example, current compiler cannot compile this: a = [1, 2, 3] a[ index: 1, ] # Syntax error in foo.cr:4: expected named argument, not ] Because the compiler does not allow comma after named arguments in index notation. This fixes it so above is now working.
Closed
makenowjust
changed the title
|
🏓 |
mverzilli
approved these changes
Aug 16, 2017
|
Using that emoji made it really difficult for me not to approve this PR :D |
|
Sorry. 🏓 means ping pong (table tennis), so I intended just "ping". |
RX14
approved these changes
Aug 16, 2017
makenowjust
deleted the
fix/crystal-parser/allow-trailing-comma-in-index
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4782
For example, current compiler cannot compile this:
Because the compiler does not allow trailing comma after named arguments in index notation. This fixes it so above is now working.
Crystal::Parser#parse_named_argsmisses checking:"]"token following:","token (this means the case of trailing comma in index notation.). I fixed this correctly.