Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: fix typo in setup.sh #28079

Merged
merged 1 commit into from Aug 9, 2017
Merged

stdenv: fix typo in setup.sh #28079

merged 1 commit into from Aug 9, 2017

Conversation

lheckemann
Copy link
Member

Motivation for this change

I think that's a typo!

Thanks @andychu for finding it (cf oilshell/oil#26 )!

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Ericson2314
Ericson2314 approved these changes Aug 9, 2017
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it's a typo. I also fixed in #28057 if we want to avoid less rebuilds....but we've had a lot already so whatever.

Good catch!

@Ericson2314 Ericson2314 merged commit d119385 into NixOS:staging Aug 9, 2017
@lheckemann lheckemann deleted the setup-typo-fix branch August 10, 2017 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
1.severity: mass-rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lheckemann @Ericson2314 @copumpkin