Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-machine: 0.12.0 -> 0.12.2 #28078

Merged
merged 1 commit into from Aug 10, 2017
Merged

docker-machine: 0.12.0 -> 0.12.2 #28078

merged 1 commit into from Aug 10, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 9, 2017

Motivation for this change
Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mikefaille, @1755 and @offlinehacker to be potential reviewers.

@NeQuissimus NeQuissimus merged commit 55fcd5c into NixOS:master Aug 10, 2017
@lsix lsix deleted the update_docker_machine branch August 22, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @mention-bot @NeQuissimus