Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHC 7.10 config of vector and tasty-ant-xml #28080

Closed
wants to merge 1 commit into from

Conversation

cocreature
Copy link
Contributor

@cocreature cocreature commented Aug 9, 2017

Motivation for this change

They don’t built without this change :)

Things done

Updated the GHC 7.10 config of vector and tasty-ant-xml.

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@cocreature cocreature force-pushed the ghc-7.10 branch 2 times, most recently from 59abe92 to 3e15892 Compare August 9, 2017 17:27
@cocreature
Copy link
Contributor Author

cocreature commented Aug 9, 2017

I know I’m not supposed to edit hackage-packages.nix but I haven’t yet figured out the file that I need to edit to get that additional verison of tasty-ant-xml.
EDIT: nvm found it, I’ll have it fixed in a few minutes.

@cocreature
Copy link
Contributor Author

Closing since 6883119 has been merged.

@cocreature cocreature closed this Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant