Skip to content

Commit

Permalink
p11_kit: fix docs
Browse files Browse the repository at this point in the history
  • Loading branch information
globin committed Aug 1, 2017
1 parent f747594 commit 93d80f1
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pkgs/development/libraries/p11-kit/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{ stdenv, fetchFromGitHub, autoreconfHook, which, pkgconfig, libiconv, libffi, libtasn1 }:
{ stdenv, fetchFromGitHub, autoreconfHook, which, pkgconfig, libiconv
, libffi, libtasn1, gtk_doc, libxslt, docbook_xsl }:

stdenv.mkDerivation rec {
name = "p11-kit-${version}";
Expand All @@ -14,7 +15,7 @@ stdenv.mkDerivation rec {
outputs = [ "out" "dev" "devdoc" ];
outputBin = "dev";

nativeBuildInputs = [ autoreconfHook which pkgconfig ];
nativeBuildInputs = [ autoreconfHook which pkgconfig gtk_doc libxslt docbook_xsl ];
buildInputs = [ libffi libtasn1 libiconv ];

autoreconfPhase = ''
Expand All @@ -25,6 +26,7 @@ stdenv.mkDerivation rec {
"--sysconfdir=/etc"
"--localstatedir=/var"
"--without-trust-paths"
"--enable-doc"
];

installFlags = [ "exampledir=\${out}/etc/pkcs11" ];
Expand Down

3 comments on commit 93d80f1

@edolstra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes p11-kit depend on dblatex, texlive etc., so a pretty massive increase in closure size. Do we really need those docs?

@vcunat
Copy link
Member

@vcunat vcunat commented on 93d80f1 Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite a common general dilemma. Docs tools only increase build-time closure, but even that can be annoying sometimes. (Rebuild amounts, propagated failures, etc.)

@fpletz
Copy link
Member

@fpletz fpletz commented on 93d80f1 Sep 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on staging: 0a2c39e

Will be cherry-picked to 17.09.

Please sign in to comment.