Checks if cookies is empty before adding to header #3150
Merged
+86
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see greyblake/crystal-cossack#4
|
Could you try to write a spec for this? :) |
|
Oops! Forgot to include it in this branch. See latest update for specs. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see greyblake/crystal-cossack#4
One item that is unclear is if it should erase the previous cookies if there are none in the instance of
HTTP::Cookies.I erred on the side of erasing them still, since I assume the canonical representation of the cookies is more likely to be the instance of
HTTP::Cookies.