Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: be0e84c880fc
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a6eb5e5462ef
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 7, 2016

  1. Copy the full SHA
    f5a4910 View commit details
  2. Copy the full SHA
    a6eb5e5 View commit details
Showing with 3 additions and 1 deletion.
  1. +1 −1 spec/ruby/shared/process/spawn.rb
  2. +2 −0 spec/truffle/tags/core/kernel/spawn_tags.txt
2 changes: 1 addition & 1 deletion spec/ruby/shared/process/spawn.rb
Original file line number Diff line number Diff line change
@@ -258,7 +258,7 @@
it "does not unset environment variables included in the environment hash" do
lambda do
Process.wait @object.spawn({"FOO" => "BAR"}, 'ruby', fixture(__FILE__, "env.rb"), unsetenv_others: true)
end.should output_to_fd("FOO=BAR\n")
end.should output_to_fd("BAR")
end

# :pgroup
2 changes: 2 additions & 0 deletions spec/truffle/tags/core/kernel/spawn_tags.txt
Original file line number Diff line number Diff line change
@@ -52,6 +52,8 @@ fails:Kernel#spawn when passed close_others: true does not close STDERR
fails:Kernel.spawn when passed close_others: true does not close STDIN
fails:Kernel.spawn when passed close_others: true does not close STDOUT
fails:Kernel.spawn when passed close_others: true does not close STDERR
fails(flakey on Travis):Kernel#spawn when passed close_others: false closes file descriptors >= 3 in the child process because they are set close_on_exec by default
fails(flakey on Travis):Kernel.spawn when passed close_others: false closes file descriptors >= 3 in the child process because they are set close_on_exec by default
slow:Kernel#spawn redirects STDOUT to the given file if out: String
slow:Kernel#spawn redirects STDOUT to the given file if out: [String name, String mode]
slow:Kernel#spawn redirects STDERR to the given file if err: String