Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1663 for HTTP::WebSocket::Protocol.read_size #3113

Merged
merged 5 commits into from
Aug 8, 2016
Merged

Fix #1663 for HTTP::WebSocket::Protocol.read_size #3113

merged 5 commits into from
Aug 8, 2016
+26 −5

Conversation

CodeSteak
Copy link
Contributor

#1663 is still present in HTTP::WebSocket::Protocol.read_size.

See RFC 6455 Section 5.2.

Payload length: 7 bits, 7+16 bits, or 7+64 bits

  The length of the "Payload data", in bytes: [...]  If 127, the
  following 8 bytes interpreted as a 64-bit unsigned integer [...].

@jhass
Copy link
Member

jhass commented Aug 7, 2016

Do you think you could write a spec for this?

@CodeSteak
Copy link
Contributor Author

I will try 😄

@CodeSteak
Copy link
Contributor Author

Ok, done 😅

@jhass
Copy link
Member

jhass commented Aug 8, 2016

Please run the formatter

@jhass
Copy link
Member

jhass commented Aug 8, 2016

Mh, it seems to segfault on the linux builds but only with the new compiler.

@CodeSteak
Copy link
Contributor Author

currently master also fails.

@jhass
Copy link
Member

jhass commented Aug 8, 2016

Oh, I didn't notice.

@asterite
Copy link
Member

asterite commented Aug 8, 2016

I'll fix the build later today, I didn't have time to do it yet

@jhass
Copy link
Member

jhass commented Aug 8, 2016

Could you rebase so we get a green build? :)

@jhass
Copy link
Member

jhass commented Aug 8, 2016

Well that rebase went wrong. Try the following:

git remote add upstream https://github.com/crystal-lang/crystal.git
git fetch upstream
git checkout websock-length-fix
git rebase -i upstream/master
# Remove the lines for all commits that are not yours, save & quit
git push -f origin websock-length-fix

@CodeSteak
Copy link
Contributor Author

Hmmm, okey. Thanks for your help! 👍 I'm kind of new to git I have to admit. Is it okey like this? 😁

@jhass jhass added this to the 0.19.0 milestone Aug 8, 2016
@jhass jhass merged commit d493f0e into crystal-lang:master Aug 8, 2016
@jhass
Copy link
Member

jhass commented Aug 8, 2016

Thank you!

@CodeSteak CodeSteak deleted the websock-length-fix branch August 8, 2016 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic:stdlib
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CodeSteak @jhass @asterite