Full Socket::Option support #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etehtsea
force-pushed
the
getset-option-linger
branch
3 times, most recently
from
da90e88
to
5091cef
Compare
etehtsea
force-pushed
the
getset-option-linger
branch
from
5091cef
to
8cc3ddb
Compare
|
@headius: I need this to be merged somewhere to move on. I can retarget it to another branch if needed. |
For example:
Socket::Option.new(:UNSPEC, :SOCKET, :SO_LINGER, [0, 0].pack('i*')
Fixes jruby#3438
Covers address family, protocol family, socket type, and protocol.
For example: Socket::Option.int(:AF_UNSPEC, :SOL_SOCKET, :LINGER, 1) Fixes jruby#3438
Also cover socket level and socket option
etehtsea
force-pushed
the
getset-option-linger
branch
from
8cc3ddb
to
1902354
Compare
|
🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Socket::Optionsupport;Socket::Optionassetsockoptargument;SOL_LEVEL,SO_OPTION) (fix for the BasicSocket#getsockopt does not work with all possible Symbol combinations #3438);