Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sf425 svd #191

Closed
wants to merge 2 commits into from
Closed

Sf425 svd #191

wants to merge 2 commits into from

Conversation

d-lamb
Copy link
Member

@d-lamb d-lamb commented Aug 4, 2016

No description provided.

@d-lamb
Add clarifying documentation and tests for svd().
5e9e5d0 
The example in the docs was using the matrix v directly instead of
the transpose.  Doesn't matter for 2x2 matrices, but does for larger.
Hopefully this clears things up.

I also added some tests for svd: square matrices, and rectangular
matrices where m>n and m<n.
@d-lamb
Heavily comment svd.c.
41c9d93 
Some comments taken from Nash (1990), some are my own to aid in
understanding this algorithm.
@coveralls
Copy link

coveralls commented Aug 4, 2016 •
edited

Coverage Status

Coverage remained the same at 62.696% when pulling 41c9d93 on sf425_svd into 015d9fe on master.

@wchristian wchristian closed this Aug 4, 2016
@wchristian wchristian deleted the sf425_svd branch August 4, 2016 21:21
@zmughal
Copy link
Member

zmughal commented Aug 4, 2016

@d-lamb++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-lamb @coveralls @zmughal @wchristian