Extended the JavaDoc to point to the data source (closes #1381) #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No probs - looks good to me but will let Tomas confirm. |
|
Hi Egon, Looks good to me! Perhaps you could add a URL of the current location of the BODR data? (is it https://github.com/egonw/bodr/tree/master/bodr?) Thanks, Tomas |
|
Oops... well, that was what the two a-href's were for... but I forgot to add the links, and did not notice that :( peer review++ |
egonw
force-pushed
the
patch/isotopeJavaDoc
branch
from
8d8f8e7
to
2845a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
John, I have asked the submitter of the bug (Tomas) to review the patch (too).