Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global data (Issue #2477) #2478

Merged
merged 2 commits into from Aug 28, 2016
Merged

global data (Issue #2477) #2478

merged 2 commits into from Aug 28, 2016

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Aug 27, 2016

Sure, it could use some error checking, some consistency checking, some non-overlapping checking, but it's the important bit.

@@ -956,6 +956,20 @@ In that case, the template engine used will be your theme's and the arguments yo
as well as the global context from your ``conf.py``, are available to the template you
are creating.

.. sidebar:: The Global Context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a full section. We should also have some information about .. data: in a more discoverable place than the large „other metadata fields” sidebar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a separate branch with those. The "other metadata" should not be a sidebar anymore, either.

@Kwpolska
Copy link
Member

👍 from me

@ralsina ralsina merged commit 8eafc13 into master Aug 28, 2016
@ralsina ralsina deleted the global-data branch August 28, 2016 11:03
Kwpolska added a commit that referenced this pull request Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants