make sure the second callback does not get executed before the event …

…loop has been started
mojolicious · Aug 28, 2016 · 637ff48 · 637ff48
1 parent 8bfafaa
commit 637ff48
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/lib/Mojo/IOLoop/Subprocess.pm b/lib/Mojo/IOLoop/Subprocess.pm
@@ -42,8 +42,8 @@ sub run {
     close => sub {
       waitpid $self->{pid}, 0;
       return $self->$parent("Non-zero exit status (@{[$? >> 8]})") if $?;
-      my $result = eval { $self->deserialize->($buffer) } || [];
-      $self->$parent(shift(@$result) // $@, @$result);
+      my $results = eval { $self->deserialize->($buffer) } || [];
+      $self->$parent(shift(@$results) // $@, @$results);
     }
   );
   return $self;

diff --git a/t/mojo/subprocess.t b/t/mojo/subprocess.t
@@ -17,13 +17,14 @@ $subprocess->run(
   sub { shift->pid . $$ . ('x' x 100000) },
   sub {
     my ($subprocess, $err, $two) = @_;
-    $fail   = $err;
-    $result = $two;
+    $fail = $err;
+    $result .= $two;
   }
 );
+$result = $$;
 Mojo::IOLoop->start;
 ok !$fail, 'no error';
-is $result, 0 . $subprocess->pid . ('x' x 100000), 'right result';
+is $result, $$ . 0 . $subprocess->pid . ('x' x 100000), 'right result';
 
 # Custom event loop
 ($fail, $result) = ();