Fake wget #17392
Closed
Fake wget #17392
+49
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-martin, thanks for your PR! By analyzing the annotation information on this pull request, we identified @wmertens, @mirrexagon and @7c6f434c to be potential reviewers |
joachifm
added
the
9.needs: reporter feedback
|
The behaviour of |
|
👎 on this. It seems to ad hoc to be generally useful. Probably in most cases where you need a mock wget, you would need it to return some fake data as well. |
|
@rasendubi I think they both ought to fail, though. This is illustrative of why I think we'd be better off with a shared utility rather than ad-hoc solutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I found myself needing a mock
wgetexecutable for a new package I'm working on to get itsconfigurescript working, and I discovered that several ad-hoc solutions for this already exist in thepreConfigurephases of a few derivations innixpkgs.Having a package for this removes a bit of duplicated code, but I think more significantly it makes life a little easier for authors of future packages that may find this useful (as I do in the package I'm currently working on), and provides a place to document the technique.
Future work
There is a slightly more complex variant of this in
xenwhich, instead of just failing, implementswgetin a mock way that copies files from a local cache. It may be useful to expand this at some point to include a behavior along those lines.Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)