You included the run/saves directory.

Fixed.

Maybe you should stick that 200 in a static constant to avoid differences between furnace / itemstack's default when the default duration ever changes.

Would it really change? And if it does, the patch in TileEntityFurnace would fail, giving the hint.

Any reason this is stored in the item? It prevents someone from adding a custom recipe for a vanilla item that is a different length than normal (eg, smelting obsidian into x taking 1000 ticks).

I would personally use a stack based map for this kinda like what is used for the furnace XP. Just add an additional function to the GameRegistry that sets the cook time (with the other furnace recipe functions) and pull that value for the cook time (or 200 if unset)

I'll wait to see what @LexManos / @cpw think about that :)

I'm a bit worried about this.
Ideally we would rip out the entire system and find a way to move to a more IFurnaceRecipe{matches(input); getOutput(input); getBurnTime(input); }
That way you could do cool things like have a prioritized system, and have OreDictFurnaceRecipe, which takes all 'oreGold' and spits out minecraft:gold_ingot.
As Knight brings up a good point people quite often modify vanilla recipes if we move this to a system like that, then we'd be better off allowing for that style of control on vanilla as well.

I definitely don't see why the burn time would go into the recipe. That would mean all recipes would need to know about all possible fuels? That doesn't solve the problem.

@diesieben07 I do like Lex's idea more for versatility - and can't getBurnTime simply query the item's "default cook time" in doubt?

I was being stupid and didn't remember what my own PR was about (it was 2 am in my defense).
I'll update this.

Updated as per the suggestions to now be a generic smelting recipe registry.

just a curious question, could that system be extended to cover all processing recipes (e.g. smelting, macerating, alloy smelting, ...) in a generic way?

@BluGen #1400 #1617

@williewillus added labels [Feature]

Does this have any chance at being accepted soon? Just wondering, since I'm holding off on updating one of my mods in hopes to include custom smelting times.

1. Probably best to split the vanilla recipe into multiple recipes of a simple 1 item input 1 item output.
2. Needs license headers
3. Needs sorting mechanic like crafting recipes.
   Beyond that we need to take some time to see how performant it is. and then make sure all binary compatibility is maintained.

NEVER hold off updating normal mods waiting on a PR, who knows if this will actually ever get in.
We have to see.
If it ever does you can add the feature you want to use using this later.

The updates will have to wait for a few days, my laptop (only proper computer I have) is currently in repair and the netbook I am using right now is lagging behind updating the screen as I type this text... So yeah, not going to run an IDE on this.

Any update on this? I am mainly interested in the ability to make a furnace recipe use NBT to determine the NBT of the output

Computer and other troubles have kept me from updating this. Soon™.

How about experience rewards?

@liach MC grants experience when you pick up the items, using <item exp> * <stack size>, so it would require too many changes to make the XP be accumulated "per recipe".

It seems that currently item exp is handled by item instances.

Yes, and since it's just the item's exp * stack size, it is all computed on the fly, when you pick up from the slot. Moving this to the recipe would require adding an "accumulated xp" to the furnace, which is way outside the scope of the PR.

Any update on this?

Updating to 1.11.x as we speak, new PR incoming.